Use AdhocWorkspace instead of MSBuildWorkspace #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahalzel
force-pushed
the
dev/zahalzel/adhoc_workspace
branch
from
7cde59d to
af7462c
Compare
zahalzel
commented
Aug 16, 2022
test/Shared/Microsoft.DotNet.Scaffolding.Shared.Tests/CodeAnalysisHelperTests.cs
Show resolved
Hide resolved
deepchoudhery
approved these changes
Aug 16, 2022
test/Shared/Microsoft.DotNet.Scaffolding.Shared.Tests/CodeAnalysisHelperTests.cs
Show resolved
Hide resolved
deepchoudhery
added a commit
that referenced
this pull request
Sep 1, 2022
* update Versions.props to preview 8. * Use Document.Name for filepath Co-authored-by: deepchoudhery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes CodeAnalysisHelper to use AdhocWorkspace instead of MSBuildWorkspace
With this change, Document filepaths are always found via Document.Name whereas before, .cs files had the filepath stored in Document.FilePath